feat: Migrate bridge to app router #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
chrstph-dvx
force-pushed
the
portal/01-setup
branch
2 times, most recently
from
bdb4705 to
0fbf360
Compare
chrstph-dvx
commented
Aug 18, 2025
| return `/?${params.toString()}` | ||
| } | ||
|
|
||
| async function sanitizeAndRedirect(searchParams: { |
There was a problem hiding this comment.
This replaces our old getServerSideProps (not supported in app router)
Comment on lines
+253
to
265
| if (!fromChainId) { | ||
| return NextResponse.json( | ||
| { message: 'fromChainId is required', data: null }, | ||
| { status: 400 } | ||
| ) | ||
| } | ||
|
|
||
| if (!toChainId) { | ||
| return NextResponse.json( | ||
| { message: 'toChainId is required', data: null }, | ||
| { status: 400 } | ||
| ) | ||
| } |
There was a problem hiding this comment.
Those two checks were added because of Typescript (but it does make sense to have them)
| - Example - to set the value of `?amount=` in browser, simply use | ||
| `const [, setQueryParams] = useArbQueryParams()` | ||
| `setQueryParams(newAmount)` | ||
There was a problem hiding this comment.
This file was split, otherwise importing it on server-side would fail (use-query-params doesn't support server side import)
| import { getArbitrumNetwork } from '@arbitrum/sdk' | ||
| import { sanitizeNullSelectedToken } from '../util/queryParamUtils' | ||
|
|
||
| export { sanitizeNullSelectedToken } from '../util/queryParamUtils' |
There was a problem hiding this comment.
This export is to minimize the diff, we can change it in a later PR
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
b31586f to
776c495
Compare
chrstph-dvx
force-pushed
the
portal/01-setup
branch
from
0fbf360 to
6c16e75
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
776c495 to
6a16891
Compare
chrstph-dvx
force-pushed
the
portal/01-setup
branch
from
6c16e75 to
f3e6fac
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
6a16891 to
45d0284
Compare
chrstph-dvx
force-pushed
the
portal/01-setup
branch
from
f3e6fac to
9c0140a
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
45d0284 to
e7974e1
Compare
chrstph-dvx
force-pushed
the
portal/01-setup
branch
from
9c0140a to
d1e4dcc
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
e7974e1 to
66c544d
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
66c544d to
91f5f87
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
91f5f87 to
2c890b8
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
2c890b8 to
8808e98
Compare
chrstph-dvx
changed the title
dewanshparashar
approved these changes
Aug 25, 2025
chrstph-dvx
force-pushed
the
portal/01-setup
branch
from
83341b5 to
83fb6e0
Compare
chrstph-dvx
force-pushed
the
portal/02-app
branch
from
14063a9 to
88f0521
Compare
douglance
approved these changes
Aug 27, 2025
chrstph-dvx
added a commit
that referenced
this pull request
Aug 27, 2025
chrstph-dvx
added a commit
that referenced
this pull request
Aug 28, 2025
chrstph-dvx
added a commit
that referenced
this pull request
Aug 29, 2025
chrstph-dvx
added a commit
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2595. This PR is part of a stack created with Aviator.
portal/03-portalmasterSummary
Steps to test