Skip to content

refactor: route management architecture #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Sep 8, 2025
Merged

refactor: route management architecture #2627

merged 32 commits into from
Sep 8, 2025

Conversation

dewanshparashar
Copy link
Contributor

@dewanshparashar dewanshparashar commented Sep 8, 2025 •
edited
Loading

Refactors route management to centralize state, remove stateful child components, and improve scalability for future route-based features.

Enhanced State Management

  1. Enhanced useRouteStore with centralized route data and eligibility tracking
  2. Removed stateful child components that couldn't be accessed from other places in code - eg. Lifi
  3. Added useRoutesUpdater hook for centralized route calculations

🚀 Future Benefits

This refactor enables us to:

  1. Pre-select the best routes for enhanced user-experience
  2. Base gas estimation on selected route (later)
  3. Calculate max amounts dynamically per route (later)

@dewanshparashar
dev: first draft of central route store
b05289e
@dewanshparashar
dev: updates
67eb0e1
@dewanshparashar
dev: updates
7e69a7c
@dewanshparashar
dev: enhance data structure
a025c8c
@dewanshparashar
dev: avoid lifi api calls
aa8bf96
@dewanshparashar
add back tag logic
4654861
@dewanshparashar
dev: get duration and stuff back
aa8eca7
@dewanshparashar
dev: token override back
ee089bd
@dewanshparashar
dev: tagging taken care of
a6fb001
@dewanshparashar
dev: low liquidity stuff added back
12c552e
@dewanshparashar
dev: min diff
c4372aa
@dewanshparashar
make duration same
2faf947
@dewanshparashar
fix: duration
f65bebf
@dewanshparashar
dev: remmove error
92ada07
@dewanshparashar
dev: move badges to routes
58e5aa2
@dewanshparashar
dev: min diffing
0e8de23
@dewanshparashar
dev: oft mindif
9730cd8
@dewanshparashar
dev: mindiffing
f8ee39d
@dewanshparashar
dev: array based ds
93f918a
@dewanshparashar
dev: formatting
d570846
@dewanshparashar
dev: hidden routes
6e683c6
@dewanshparashar
removed unnecessary comments
8d8da3a
@dewanshparashar
dev: eligible route types
dfef7b8
@dewanshparashar
review comments
192e1a2
@dewanshparashar
dev: review comments
ecf4c96
@dewanshparashar
testnet flag inside function
f1333d7
@dewanshparashar
dev: review comments
fff0405
@dewanshparashar
dev: review comment
1bc5363
@dewanshparashar
dev: update route data ds
5aacd43
@dewanshparashar
dev: remove updateRouteData
9550a93
@cla-bot cla-bot bot added the cla-signed label Sep 8, 2025
@vercel Vercel
Copy link

vercel bot commented Sep 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
arbitrum-token-bridge Ready Ready Preview Sep 8, 2025 11:27am

@dewanshparashar dewanshparashar marked this pull request as ready for review September 8, 2025 10:39
fionnachan
fionnachan approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@fionnachan fionnachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spsjvc spsjvc merged commit 95ece86 into master Sep 8, 2025
441 of 462 checks passed
@spsjvc spsjvc deleted the fs-1396/pre-select-best-route branch September 8, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrstph-dvx chrstph-dvx chrstph-dvx approved these changes

@fionnachan fionnachan fionnachan approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dewanshparashar @chrstph-dvx @fionnachan @spsjvc