Skip to content

fix: reset destination address properly #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reset destination address properly #2636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/arb-token-bridge-ui/src/components/TransferPanel/SettingsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ export const SettingsDialog = React.memo((props: UseDialogProps) => {
setQueryParams({ destinationAddress: undefined })
setDestinationAddress(undefined)
} else {
setQueryParams({ destinationAddress })
// If string is empty, we want to remove the param from URL (passing undefined)
setQueryParams({
destinationAddress: destinationAddress || undefined
})
}
}}
isFooterHidden
Expand Down
7 changes: 4 additions & 3 deletions packages/arb-token-bridge-ui/src/hooks/useArbQueryParams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ export const useArbQueryParams = () => {
setQueryParams (setter for all query state variables with debounced accumulator)
]
*/
const [queryParams, setQueryParams] = useQueryParams()
const [queryParams, setQueryParams] =
useQueryParams<typeof queryParamProviderOptions.params>()

const debouncedSetQueryParams = useCallback(
(
Expand All @@ -145,7 +146,7 @@ export const useArbQueryParams = () => {
return [queryParams, debouncedSetQueryParams] as const
}

export const queryParamProviderOptions: QueryParamOptions = {
export const queryParamProviderOptions = {
searchStringToObject: queryString.parse,
objectToSearchString: queryString.stringify,
updateType: 'replaceIn', // replace just a single parameter when updating query-state, leaving the rest as is
Expand All @@ -164,7 +165,7 @@ export const queryParamProviderOptions: QueryParamOptions = {
mode: withDefault(ModeParam, undefined), // mode: 'embed', or undefined for normal mode
theme: withDefault(ThemeParam, defaultTheme) // theme customization
}
}
} as const satisfies QueryParamOptions
export function ArbQueryParamProvider({
children
}: {
Expand Down
Loading