Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 18, 2025

Related to NIT-3523
Pulled in OffchainLabs/nitro#3397

ProcessAllAssertionsInRange is called in two scenarios:

  1. During startup — when the system processes from the last confirmed assertion to the latest block.

    • This case was already handled by splitting the getLogs query into smaller batch FilterOpts to avoid exceeding the block limit.
  2. During regular polling — when the system polls at a configured interval.

    • The assumption was that regular polling would naturally limit the batch size. However, since the polling interval is configurable, the block range could still exceed the limit.

This PR ensures that even during the polling flow, getLogs queries are broken down into smaller batch FilterOpts, preventing potential block limit issues in both scenarios.

@amsanghi amsanghi marked this pull request as ready for review July 18, 2025 10:48
@eljobe eljobe requested a review from tsahee July 22, 2025 19:01
@tsahee tsahee assigned amsanghi and unassigned tsahee Jul 23, 2025
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fails build.

@tsahee tsahee assigned rauljordan and tsahee and unassigned amsanghi Jul 23, 2025
@tsahee tsahee merged commit 25846c3 into main Jul 23, 2025
5 checks passed
@tsahee tsahee deleted the getlogs_small_chunks branch July 23, 2025 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants