Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

rauljordan
Copy link
Collaborator

@rauljordan rauljordan commented Jul 29, 2025

Validators that have auto-deposit functionality on exhibiter some strange behavior that would cause them to deposit twice. The situation was as follows:

  1. On startup, the challenge manager will attempt to auto-deposit ERC20 stake (wrap ETH to WETH)
  2. The validator will then perform a new stake on a new assertion, which would transfer the WETH to the rollup contract
  3. The next assertion the validator tries to post would once again attempt wrapping ETH to WETH

Instead, we skip wrapping to WETH if the validator is already staked. This PR adds a regression test that proves we only observe a single deposit event from the staker

Fixes NIT-3600

Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like this broke the assertion_test.go

@eljobe eljobe assigned rauljordan and unassigned eljobe Jul 29, 2025
@rauljordan rauljordan assigned eljobe and unassigned rauljordan Jul 29, 2025
@rauljordan rauljordan requested a review from eljobe July 29, 2025 19:35
@eljobe eljobe merged commit 30e78f6 into main Jul 29, 2025
5 checks passed
@eljobe eljobe deleted the fix-double-deposits branch July 29, 2025 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants