Skip to content

Diagnostic mode handle SIGTERM #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Diagnostic mode handle SIGTERM #80

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
011dd3e
Diagnostic mode handle SIGTERM
a-thomas-22 Sep 16, 2024
a9e512d
Merge branch 'main' into at/improve-diagnosticmode
a-thomas-22 Sep 27, 2024
af9246d
Merge branch 'main' into at/improve-diagnosticmode
a-thomas-22 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nitro/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ maintainers:

type: application

version: 0.6.17
version: 0.6.18

appVersion: "v3.2.1-d81324d"
13 changes: 11 additions & 2 deletions charts/nitro/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,17 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.diagnosticMode }}
command: ["sleep"]
args: ["infinity"]
command: ["/bin/sh"]
args:
- -c
- |
#!/usr/bin/env bash
set -eo pipefail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error when running this on a test pod /bin/sh: 2: set: Illegal option -o pipefail

Suggested change
set -eo pipefail
set -e pipefail


trap 'exit 0' SIGTERM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error when running this on a test pod trap: SIGTERM: bad trap seems like some shells expect the signal without the SIG part

Suggested change
trap 'exit 0' SIGTERM
trap 'exit 0' TERM


sleep infinity &
wait $!
{{- else if .Values.commandOverride.enabled }}
{{- with .Values.commandOverride.command }}
command: {{- toYaml . | nindent 8}}
Expand Down
Loading