Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes for Eip 2935 #412

Merged
merged 8 commits into from
Mar 10, 2025
Merged

Backport changes for Eip 2935 #412

merged 8 commits into from
Mar 10, 2025

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Feb 21, 2025

closes NIT-3105

@cla-bot cla-bot bot added the s CLA signed label Feb 21, 2025
@amsanghi amsanghi changed the title Eip 2935 Backport changes for Eip 2935 Feb 21, 2025
@amsanghi amsanghi marked this pull request as ready for review February 24, 2025 13:16
eljobe
eljobe previously approved these changes Feb 26, 2025
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I know we discussed this, but there isn't a separate Linear ticket for actually modifying the bytecode of the contract of the HistoryStorageAddress to update the size of the ring buffer. So, we either need to do it as part of this PR, or have a separate PR to get that change in as well.

I think, as it is written now, there will only be 8191 historical blocks stored.

@godzillaba
Copy link

godzillaba commented Mar 3, 2025

Sorry. I know we discussed this, but there isn't a separate Linear ticket for actually modifying the bytecode of the contract of the HistoryStorageAddress to update the size of the ring buffer. So, we either need to do it as part of this PR, or have a separate PR to get that change in as well.

I think, as it is written now, there will only be 8191 historical blocks stored.

here is a PR with modified bytecode for a larger buffer

OffchainLabs/sys-asm#1

@amsanghi
Copy link
Contributor Author

Sorry. I know we discussed this, but there isn't a separate Linear ticket for actually modifying the bytecode of the contract of the HistoryStorageAddress to update the size of the ring buffer. So, we either need to do it as part of this PR, or have a separate PR to get that change in as well.

I think, as it is written now, there will only be 8191 historical blocks stored.

Updated the bytecode

@amsanghi amsanghi requested a review from eljobe March 10, 2025 05:36
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe merged commit 8a35114 into master Mar 10, 2025
7 checks passed
@eljobe eljobe deleted the eip_2935 branch March 10, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants