-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport changes for Eip 2935 #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I know we discussed this, but there isn't a separate Linear ticket for actually modifying the bytecode of the contract of the HistoryStorageAddress to update the size of the ring buffer. So, we either need to do it as part of this PR, or have a separate PR to get that change in as well.
I think, as it is written now, there will only be 8191 historical blocks stored.
here is a PR with modified bytecode for a larger buffer |
Updated the bytecode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes NIT-3105