Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context in SyncProgressBackend #421

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Context in SyncProgressBackend #421

merged 3 commits into from
Mar 25, 2025

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Mar 7, 2025 •
edited
Loading

Relates to NIT-3058

Adds Context as argument to some functions related to SyncProgressBackend.

Pulled by OffchainLabs/nitro#3001

@cla-bot cla-bot bot added the s CLA signed label Mar 7, 2025
@diegoximenes diegoximenes changed the title Context in syncprogressbackend Context in SyncProgressBackend Mar 7, 2025
@diegoximenes diegoximenes mentioned this pull request Mar 7, 2025
Merged
@diegoximenes diegoximenes force-pushed the context_in_syncprogressbackend branch from 6bf6126 to ec7e9d0 Compare March 7, 2025 16:19
@diegoximenes diegoximenes marked this pull request as ready for review March 7, 2025 19:21
@diegoximenes diegoximenes force-pushed the context_in_syncprogressbackend branch from ec7e9d0 to 1269cec Compare March 18, 2025 17:57
@diegoximenes diegoximenes force-pushed the context_in_syncprogressbackend branch from 1269cec to 45f4694 Compare March 20, 2025 12:16
eljobe
eljobe approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe merged commit e2a1a20 into master Mar 25, 2025
7 of 8 checks passed
@eljobe eljobe deleted the context_in_syncprogressbackend branch March 25, 2025 08:01
diegoximenes added a commit that referenced this pull request Mar 25, 2025
@diegoximenes
Revert "Merge pull request #421 from OffchainLabs/context_in_syncprog…
d530451 
…ressbackend"

This reverts commit e2a1a20, reversing
changes made to d18b33c.
@joshuacolvin0 joshuacolvin0 mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

@ganeshvanahalli ganeshvanahalli Awaiting requested review from ganeshvanahalli

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

Assignees
No one assigned
Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoximenes @eljobe