-
Notifications
You must be signed in to change notification settings - Fork 148
Add configs and metrics to transaction indexer #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 14a0397.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just are a few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of NIT-3330
This PR:
runtime.NumCPU
)minBatchDelay
):txindexer/tail
gauge - tracks oldest indexed block, useful e.g. for verifying if we keep up with unindexingtxindexer/unindexed/blocks/count
andtxindexer/unindexed/transactions/count
- those expose stats about blocks / transactions unindexed in single txindexer run, useful to monitor how changingminBatchDelay
affects actual work done in each batch