Fix SlidingTimeWindowArraySample to expire metrics correctly #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ChunkedAssociativeArray.Trim method had a bug where it would fail to remove all chunks when every chunk contained only values older than the trim threshold. When indexAfterStartKey returned -1, indicating all chunks should be removed, the removal loop would not execute. This caused SlidingTimeWindowArraySample-based metrics to get stuck at their last value instead of returning to zero after the time window expired. The fix adds explicit handling for the indexAfterStartKey == -1 case to ensure all chunks are properly removed when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChunkedAssociativeArray.Trim method had a bug where it would fail to remove all chunks when every chunk contained only values older than the trim threshold. When indexAfterStartKey returned -1, indicating all chunks should be removed, the removal loop would not execute. This caused SlidingTimeWindowArraySample-based metrics to get stuck at their last value instead of returning to zero after the time window expired. The fix adds explicit handling for the indexAfterStartKey == -1 case to ensure all chunks are properly removed when needed.