Skip to content

Update gasFunc signature to return only multi-dimensional gas #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Update gasFunc signature to return only multi-dimensional gas #496

merged 2 commits into from
Jul 23, 2025

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Jul 23, 2025 •
edited
Loading

For NIT-3543

  • Update the gasFunc API to return only (*multigas.MultiGas, error)
  • For uninstrumented methods, temporarily return ResourceKindUnknown (added TODO comments)

@cla-bot cla-bot bot added the s CLA signed label Jul 23, 2025
@MishkaRogachev MishkaRogachev force-pushed the make-gas-func-return-multigas-only branch from 8fae844 to 14f9e0c Compare July 23, 2025 11:09
@MishkaRogachev MishkaRogachev force-pushed the make-gas-func-return-multigas-only branch from 14f9e0c to 14939c2 Compare July 23, 2025 11:46
@MishkaRogachev MishkaRogachev marked this pull request as ready for review July 23, 2025 11:53
eljobe
eljobe requested changes Jul 23, 2025
View reviewed changes
@eljobe eljobe assigned MishkaRogachev and unassigned eljobe Jul 23, 2025
gligneul
gligneul reviewed Jul 23, 2025
View reviewed changes
@MishkaRogachev @gligneul
Update comment in core/vm/jump_table.go
4edabf0 
Co-authored-by: Gabriel de Quadros Ligneul <[email protected]>
@eljobe eljobe enabled auto-merge July 23, 2025 14:12
@eljobe eljobe merged commit 3781510 into master Jul 23, 2025
15 checks passed
@eljobe eljobe deleted the make-gas-func-return-multigas-only branch July 23, 2025 14:12
@joshuacolvin0 joshuacolvin0 mentioned this pull request Jul 29, 2025
Closed
@gligneul gligneul mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gligneul gligneul gligneul left review comments

@eljobe eljobe eljobe approved these changes

Assignees

@eljobe eljobe

Labels

design-approved s CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MishkaRogachev @eljobe @gligneul