core: Support cell proofs (Version 1 blob sidecars) in signer library #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the go-ethereum signer library to accept and validate both Version 0 (legacy) and Version 1 (cell proof) blob transaction sidecars, which is necessary for the Fusaka/Osaka hardfork that introduces PeerDAS (Peer Data Availability Sampling). Changes to signer/core/apitypes/types.go: The validateTxSidecar() function now accepts two proof formats: - Version 0: 1 proof per blob (existing format, pre-Fusaka) - Version 1: 128 cell proofs per blob (new Fusaka format) The validation logic detects which version by checking the proof count: - If len(proofs) == len(blobs): Use VerifyBlobProof for each blob - If len(proofs) == len(blobs) * 128: Use VerifyCellProofs for all blobs When converting SendTxArgs to a Transaction, the correct sidecar version is automatically selected based on the number of proofs provided. Added TestBlobTxsWithCellProofs to verify: - Cell proof generation produces exactly 128 proofs per blob - SendTxArgs correctly accepts 128 cell proofs per blob - ToTransaction() creates a Version 1 sidecar when given cell proofs - The resulting transaction properly serializes with cell proofs
amsanghi
approved these changes
Oct 14, 2025
eljobe
approved these changes
Oct 14, 2025
eljobe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the go-ethereum signer library to accept and validate both Version 0 (legacy) and Version 1 (cell proof) blob transaction sidecars, which is necessary for the Fusaka/Osaka hardfork that introduces PeerDAS (Peer Data Availability Sampling).
Changes to signer/core/apitypes/types.go:
The validateTxSidecar() function now accepts two proof formats:
The validation logic detects which version by checking the proof count:
When converting SendTxArgs to a Transaction, the correct sidecar version is automatically selected based on the number of proofs provided.
Added TestBlobTxsWithCellProofs to verify: