eth: Remove unused gas dimension tracers #608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ArbOS 50, the multigas tracking has moved into the STF directly and reported directly in transaction receipts (with the added experimental
--execution.expose-multi-gasflag).These dimension tracers were written before that took place and are no longer necessary since you can get the data from transaction receipts and the tracers are not accurate to the final version of the multi-gas calculations which takes into account more details of the STF than we were able to consider when we were not editing the STF directly but instead guessing at what the multi-gas dimensions should be from outside the STF (inside the tracer).
This PR removes said tracers. If they are ever needed in the future for reference, one can simply peer into the commit history to get the files back.
Pulled in by OffchainLabs/nitro#4220