arbitrum: Add transaction address filtering support to eth_call#647
Open
MishkaRogachev wants to merge 6 commits intomasterfrom
Open
arbitrum: Add transaction address filtering support to eth_call#647MishkaRogachev wants to merge 6 commits intomasterfrom
MishkaRogachev wants to merge 6 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Arbitrum transaction address filtering support to eth_call, aligning behavior with gas estimation so that filtered addresses are detected consistently (including addresses touched by scheduled retryable redeems).
Changes:
- Initialize and apply
TxFiltererineth_callexecution (internal/ethapi) and verify filtering after execution. - Refactor
core.TxFiltererinterface to separate “from/to” touching from scheduled-tx touching, and rename filtering check to include event application. - Extend scheduled retryable execution helper to optionally run during non-gas-estimation calls when filtering is enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/ethapi/api.go | Sets up TxFilterer for eth_call, runs scheduled txes for filtering, and checks filter outcome. |
| eth/gasestimator/gasestimator.go | Switches to TouchFromTo and ApplyEventsAndCheckFiltered for consistent filtering behavior. |
| core/arbitrum_hooks.go | Updates TxFilterer interface to new method split/semantics. |
| arbitrum/retryables/scheduled_txes.go | Allows scheduled tx execution in non-gas-estimation mode when filtering is enabled; updates touch/check calls accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diegoximenes
requested changes
Apr 14, 2026
…tering-support-to-eth_call
diegoximenes
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NIT-4725
Pulled in by OffchainLabs/nitro#4613