Skip to content

arbitrum: Add transaction address filtering support to eth_call#647

Open
MishkaRogachev wants to merge 6 commits intomasterfrom
add-transaction-filtering-support-to-eth_call
Open

arbitrum: Add transaction address filtering support to eth_call#647
MishkaRogachev wants to merge 6 commits intomasterfrom
add-transaction-filtering-support-to-eth_call

Conversation

@MishkaRogachev
Copy link
Copy Markdown
Contributor

Part of NIT-4725
Pulled in by OffchainLabs/nitro#4613

@MishkaRogachev MishkaRogachev changed the title Add transaction address filtering support to eth_call arbitrum: Add transaction address filtering support to eth_call Apr 8, 2026
@MishkaRogachev MishkaRogachev marked this pull request as ready for review April 9, 2026 10:54
@diegoximenes diegoximenes requested a review from Copilot April 10, 2026 12:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Arbitrum transaction address filtering support to eth_call, aligning behavior with gas estimation so that filtered addresses are detected consistently (including addresses touched by scheduled retryable redeems).

Changes:

  • Initialize and apply TxFilterer in eth_call execution (internal/ethapi) and verify filtering after execution.
  • Refactor core.TxFilterer interface to separate “from/to” touching from scheduled-tx touching, and rename filtering check to include event application.
  • Extend scheduled retryable execution helper to optionally run during non-gas-estimation calls when filtering is enabled.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
internal/ethapi/api.go Sets up TxFilterer for eth_call, runs scheduled txes for filtering, and checks filter outcome.
eth/gasestimator/gasestimator.go Switches to TouchFromTo and ApplyEventsAndCheckFiltered for consistent filtering behavior.
core/arbitrum_hooks.go Updates TxFilterer interface to new method split/semantics.
arbitrum/retryables/scheduled_txes.go Allows scheduled tx execution in non-gas-estimation mode when filtering is enabled; updates touch/check calls accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/ethapi/api.go
Comment thread arbitrum/retryables/scheduled_txes.go
Comment thread arbitrum/retryables/scheduled_txes.go
Comment thread eth/gasestimator/gasestimator.go Outdated
@diegoximenes diegoximenes assigned tsahee and unassigned diegoximenes Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants