arbitrum: Add FilterSetID to FilteredAddressRecord#648
Open
MishkaRogachev wants to merge 9 commits intomasterfrom
Open
arbitrum: Add FilterSetID to FilteredAddressRecord#648MishkaRogachev wants to merge 9 commits intomasterfrom
MishkaRogachev wants to merge 9 commits intomasterfrom
Conversation
MishkaRogachev
changed the base branch from
master
to
update-touchaddress-and-hashedaddresscheckerstateisfiltered
Contributor
There was a problem hiding this comment.
Pull request overview
Adds filter set attribution to Arbitrum address-filtering reports by extending the filtered-address record model and adjusting StateDB.TouchAddress plumbing so the filter implementation can attach the active filter-set ID when producing final records.
Changes:
- Introduces
FilterSetIDonfilter.FilteredAddressRecordand factors outFilteredAddressWithReasonas the input shape. - Updates
StateDB.TouchAddress(and related interfaces/wrappers) to acceptfilter.FilteredAddressWithReasoninstead of a*FilteredAddressRecord. - Updates call sites (gas estimator + EVM selfdestruct ops) to pass
FilteredAddressWithReason.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eth/gasestimator/gasestimator.go | Updates address-touch calls to pass FilteredAddressWithReason. |
| core/vm/interface.go | Updates StateDB interface TouchAddress signature to new input type. |
| core/vm/instructions.go | Updates selfdestruct address-touch calls to new input type. |
| core/state/statedb.go | Updates StateDB.TouchAddress implementation to forward the new input type. |
| core/state/statedb_hooked.go | Updates hooked StateDB wrapper to match new signature. |
| core/state/statedb_arbitrum.go | Updates AddressCheckerState interface to accept FilteredAddressWithReason. |
| arbitrum/filter/filter_report.go | Adds FilterSetID to records and introduces FilteredAddressWithReason. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…filteredaddressrecord
MishkaRogachev
changed the base branch from
update-touchaddress-and-hashedaddresscheckerstateisfiltered
to
master
MishkaRogachev
changed the base branch from
master
to
update-touchaddress-and-hashedaddresscheckerstateisfiltered
…dresscheckerstateisfiltered' into add-filtersetid-to-filteredaddressrecord
diegoximenes
requested changes
Apr 14, 2026
| } | ||
|
|
||
| func (s *StateDB) TouchAddress(record *filter.FilteredAddressRecord) { | ||
| func (s *StateDB) TouchAddress(touched filter.FilteredAddressWithReason) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *StateDB) TouchAddress(touched filter.FilteredAddressWithReason) { | |
| func (s *StateDB) TouchAddress(touched *filter.FilteredAddressWithReason) { |
diegoximenes
previously approved these changes
Apr 15, 2026
Contributor
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
LGTM, I will keep it assigned to me while the base branch is not merged
Base automatically changed from
update-touchaddress-and-hashedaddresscheckerstateisfiltered
to
master
April 16, 2026 12:30
…filteredaddressrecord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NIT-4780
Waits OffchainLabs/nitro#4557
Pulled in by OffchainLabs/nitro#4626
Add FilterSetID field to FilteredAddressRecord and expose it through the AddressChecker and StateDB interfaces so callers can stamp each record with the active filter set id.