rpc: support wrapped errors and code-based Is for jsonError#649
Open
pmikolajczyk41 wants to merge 1 commit intomasterfrom
Open
rpc: support wrapped errors and code-based Is for jsonError#649pmikolajczyk41 wants to merge 1 commit intomasterfrom
pmikolajczyk41 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorMessagepreviously cast err directly torpc.Error/DataError, which missed errors wrapped withfmt.Errorf("%w", ...). Switch toerrors.Asso the code and data are extracted correctly from wrapped errors.(*jsonError).Isso thaterrors.Is(receivedErr, sentinel)works on the client side whenreceivedErris ajsonErrorreconstructed from the wire. Matching is by error code: if the sentinel implementsErrorCode() int, the codes are compared. This avoids the need for string-based error reconstruction in callers.pulled in by OffchainLabs/nitro#4629