Add MintNativeToken and BurnNativeToken calls #332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will allow arbOwner authorized addresses to mint some amount of the chain's native gas token to or burn some amount of the chain's native gas token from a given address. Chain owners *should* deploy a non-upgradable proxy contract, the address of which is added to the set of arbOwner addresses and then add any addresses which should be allowed to mint and burn the native gas token to call corresponding methods on the proxy contract. The implmentation of those proxy contract methods should not allow to and from address arguments, and instead use the address of the caller as the target for minting and burning. Resolves: NIT-3297
diegoximenes
approved these changes
Apr 29, 2025
|
i think it's worth considering whether we want the burner to be able to burn from any account or only their own account. currently the only way a contract's balance can be reduced is if it makes external calls with value. having the burner be able to burn from arbitrary accounts would change this. this might be weird for app devs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will allow arbOwner authorized addresses to mint some amount of the chain's native gas token to or burn some amount of the chain's native gas token from a given address.
Chain owners should deploy a non-upgradable intermediary contract, the address of which is added to the set of arbOwner addresses and then add any addresses which should be allowed to mint and burn the native gas token to call corresponding methods on the proxy contract. The implementation of those intermediary contract methods should not allow to and from address arguments, and instead use the address of the caller as the target for minting and burning.
Resolves: NIT-3297