-
Notifications
You must be signed in to change notification settings - Fork 136
Mint-Burn gas token privileged contract #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TucksonDev
wants to merge
6
commits into
mb-arbowner-dev
Choose a base branch
from
mint-burn-privileged-contract
base: mb-arbowner-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godzillaba
reviewed
Apr 29, 2025
godzillaba
reviewed
Apr 29, 2025
src/bridge/MinterBurnerForwarder.sol
Outdated
Comment on lines
43
to
47
function mintNativeToken( | ||
uint256 amount | ||
) external onlyRole(MINTER_ROLE) { | ||
ARB_OWNER.mintNativeToken(msg.sender, amount); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should do this to burn too
Suggested change
function mintNativeToken( | |
uint256 amount | |
) external onlyRole(MINTER_ROLE) { | |
ARB_OWNER.mintNativeToken(msg.sender, amount); | |
} | |
function mintNativeToken( | |
address to, | |
uint256 amount | |
) external onlyRole(MINTER_ROLE) { | |
ARB_OWNER.mintNativeToken(to, amount); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a contract that will serve as a proxy for certain privileged accounts to call the new
mintNativeToken
andburnNativeToken
functions of the ArbOwner precompile.This privileged accounts will be managed by the chain owner, who must be the deployer of this contract.
This contract must be set as a chain owner of the chain to be able to call ArbOwner functions
Closes BLK-331