Draft
Conversation
…m/OffchainLabs/nitro-contracts into deterministic-factory-deployments
…s' into impl-registry
* disable CBOR * chore: remove entries for removed files * refactor: commonSetting * feat: foundry override * fix: test * chore: default profile * format: yarn format * ci: comapre bytecodes * fix: slither db --------- Co-authored-by: gzeon <im@gzeon.dev>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Base automatically changed from
deterministic-factory-deployments
to
develop
September 9, 2025 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we could also consider moving the "get bridge from inbox, verify its implementation is expected" logic into the
ImplementationsRegistrycontract. Then we could have a function per registry calledisOnVersion(inbox, proxyAdmin)that checks that the entire chain is on a specific version.this would make it easier and safer to check the version of a specific chain (no depenedencies besides an RPC, just call a contract).
this tool would then be available even if we don't use the base upgrade action at some versions