Skip to content

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Jul 8, 2025

POC, dirty hack; should pass isSerialDeployment into internal methods instead of reading from env everytime

@gzeoneth gzeoneth requested a review from Copilot July 8, 2025 17:39
@cla-bot cla-bot bot added the s label Jul 8, 2025
Copilot

This comment was marked as outdated.

@gzeoneth gzeoneth requested a review from Copilot July 8, 2025 18:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a “NO_PARALLEL_DEPLOYMENT” feature flag to switch between parallel and serial contract deployments, introducing a deployBatch helper and mutex locking for serial mode.

  • Introduces deployLock and refactors deployment flows to respect the NO_PARALLEL_DEPLOYMENT env var.
  • Adds a deployBatch helper to sequence or parallelize deployment functions.
  • Updates deployContract, create2, deployAllContracts, and deployOneStepProofEntry to use serial/parallel logic.
Comments suppressed due to low confidence (2)

scripts/deploymentUtils.ts:140

  • [nitpick] The local variable useSerialDeployment is named differently from isSerialDeployment used elsewhere. Consider unifying this to a single name for consistency.
    const useSerialDeployment = process.env.NO_PARALLEL_DEPLOYMENT === 'true'

scripts/deploymentUtils.ts:188

  • [nitpick] The new deployBatch helper implementing serial vs. parallel flows is not covered by existing tests. Adding unit tests or integration tests for both modes will help prevent regressions.
async function deployBatch<T>(

@gzeoneth gzeoneth closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant