Skip to content

fix: yul only build faling on forge v1.3.x #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: yul only build faling on forge v1.3.x #381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
744de73
fix: disable linting on yul only build
mkykadir Sep 11, 2025
139aebe
chore: disable forge lint_on_build for all profile
gzeoneth Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ remappings = []
auto_detect_remappings = false
skip = ['*.sol', 'test/*']

[profile.yul.lint]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[profile.yul.lint]
[lint]

Copy link
Author

@mkykadir mkykadir Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this disables linting for all profiles, any specific reason to disable for all of them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using this new foundry feature at the moment

lint_on_build = false

[fmt]
line_length = 100
tab_width = 4
Expand Down