fix: add zero address check for bridge parameter in ERC20MigrationOutbox constructor#382
Open
CreeptoGengar wants to merge 1 commit intoOffchainLabs:mainfrom
Open
fix: add zero address check for bridge parameter in ERC20MigrationOutbox constructor#382CreeptoGengar wants to merge 1 commit intoOffchainLabs:mainfrom
CreeptoGengar wants to merge 1 commit intoOffchainLabs:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing zero address validation for _bridge parameter in ERC20MigrationOutbox constructor to prevent potential runtime errors when bridge.nativeToken() is called with a null bridge reference. This follows the existing pattern of zero address checks in the codebase and uses the established InvalidDestination error.