-
Notifications
You must be signed in to change notification settings - Fork 1
Add a getNativeTokenManagementFrom precompile #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new precompile getter to expose when native token management was enabled.
- Introduces
getNativeTokenManagementFrom
toArbOwnerPublic
interface. - Documents availability in ArbOS version 42.
Comments suppressed due to low confidence (2)
ArbOwnerPublic.sol:27
- [nitpick] It may be helpful to specify the unit for the returned timestamp (e.g., seconds since Unix epoch) in the documentation.
/// @notice Retrieves the timestamp from when the native token maagement
ArbOwnerPublic.sol:27
- [nitpick] The comment block uses a tab for indentation; consider using spaces to match the file's existing style.
/// @notice Retrieves the timestamp from when the native token maagement
This is available on ArbOwnerPublic because it can be useful to inspect for non-ArbOwner accounts (especially, the accounts to which the mint burn authorization has been granted.) Part of: NIT-3524
Co-authored-by: Copilot <[email protected]>
9f37833
to
fa0d94a
Compare
gzeoneth
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tristan-Wilson
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is available on ArbOwnerPublic because it can be useful to inspect for non-ArbOwner accounts (especially, the accounts to which the mint burn authorization has been granted.)
Part of: NIT-3524