-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add arbos 30 methods #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting one change, or at least, confirm that types should be different
/// @notice Available in ArbOS version 30 and above | ||
/// @param gas amount of gas paid in increments of 256 when not the program is not cached | ||
/// @param cached amount of gas paid in increments of 64 when the program is cached | ||
function setWasmMinInitGas(uint8 gas, uint16 cached) external; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential type mismatch. Both gas
and cached
are marked as uint64 in the implementation file (here).
* refactor: remove arbos 41 methods * refactor: remove arbos 40 methods * refactor: remove arbos 31 methods * refactor: remove arbos 30 methods * refactor: remove arbos 20 methods * refactor: remove arbos 11 methods * refactor: remove arbos 10 methods * refactor: remove arbos 5 methods * docs: add LICENSE.md * chore: set up repo and ci * docs: add README.md * ci: push * ci: fix wrong path * chore: commit yarn lock * format: fix * chore: remove ChainOwnerRectified
* refactor: remove arbos 41 methods * refactor: remove arbos 40 methods * refactor: remove arbos 31 methods * refactor: remove arbos 30 methods * refactor: remove arbos 20 methods * refactor: remove arbos 11 methods * refactor: remove arbos 10 methods * refactor: remove arbos 5 methods * docs: add LICENSE.md * chore: set up repo and ci * docs: add README.md * ci: push * ci: fix wrong path * chore: commit yarn lock * feat: add arbos 5 methods * format: fix * chore: 5.0.0 * chore: remove ChainOwnerRectified
* refactor: remove arbos 41 methods * refactor: remove arbos 40 methods * refactor: remove arbos 31 methods * refactor: remove arbos 30 methods * refactor: remove arbos 20 methods * refactor: remove arbos 11 methods * refactor: remove arbos 10 methods * refactor: remove arbos 5 methods * docs: add LICENSE.md * chore: set up repo and ci * docs: add README.md * ci: push * ci: fix wrong path * chore: commit yarn lock * feat: add arbos 5 methods * feat: add arbos 10 methods * format: fix * chore: 5.0.0 * chore: 10.0.0 * chore: remove ChainOwnerRectified
* refactor: remove arbos 41 methods * refactor: remove arbos 40 methods * refactor: remove arbos 31 methods * refactor: remove arbos 30 methods * refactor: remove arbos 20 methods * refactor: remove arbos 11 methods * refactor: remove arbos 10 methods * refactor: remove arbos 5 methods * docs: add LICENSE.md * chore: set up repo and ci * docs: add README.md * ci: push * ci: fix wrong path * chore: commit yarn lock * feat: add arbos 5 methods * feat: add arbos 10 methods * feat: add arbos 11 methods * format: fix * chore: 5.0.0 * chore: 10.0.0 * chore: 11.0.0 * chore: remove ChainOwnerRectified * feat: ChainOwnerRectified
No description provided.