Skip to content

V3 support #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Jun 18, 2025
Merged

V3 support #117

merged 51 commits into from
Jun 18, 2025

Conversation

yahgwai
Copy link
Contributor

@yahgwai yahgwai commented Feb 9, 2025 •
edited by gzeoneth
Loading

@cla-bot cla-bot bot added the s label Feb 9, 2025
@yahgwai yahgwai marked this pull request as draft February 21, 2025 15:39
@gzeoneth gzeoneth mentioned this pull request Mar 17, 2025
Merged
@gzeoneth gzeoneth changed the base branch from release to master March 17, 2025 10:18
@gzeoneth gzeoneth marked this pull request as ready for review April 16, 2025 17:51
@gzeoneth
Copy link
Member

I think we can merge this and resolve the outstanding TODOs later

@gzeoneth gzeoneth requested review from godzillaba and tsahee April 17, 2025 16:53
TucksonDev
TucksonDev previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@TucksonDev TucksonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Summarizing the open issues (we can potentially tackle these in a different PR):

  • Issues with use-smart-contract-wallet : pointed out in this comment
  • Issues with gas estimations sent from address 0x0. A workaround is in place here.
  • This PR pins geth version to v1.14.13

@gzeoneth
Copy link
Member

wait for nitro-contracts v3.1.1 release for OffchainLabs/nitro-contracts#338 change before merge

@gzeoneth
Copy link
Member

Ready to merge, with v3.1.1 stylus deployer factory (surfacing constructor error) it would be deployed at 0xcEcba2F1DC234f70Dd89F2041029807F8D03A990

@tsahee tsahee changed the base branch from master to release June 17, 2025 17:34
@tsahee tsahee changed the base branch from release to master June 17, 2025 17:35
@gzeoneth gzeoneth changed the base branch from master to release June 17, 2025 18:06
@tsahee tsahee merged commit 06ced35 into release Jun 18, 2025
26 checks passed
@tsahee tsahee deleted the v3-support branch June 18, 2025 01:10
@davebryson davebryson mentioned this pull request Jun 21, 2025
Closed
gligneul added a commit to OffchainLabs/nitro-devnode that referenced this pull request Jun 24, 2025
@gligneul
Update Stylus Deployer bytecode
81dce44 
Apply the changes from OffchainLabs/nitro-testnode#117
The new CREATE2 address is 0xcEcba2F1DC234f70Dd89F2041029807F8D03A990

Close STY-280
@gligneul gligneul mentioned this pull request Jun 24, 2025
Merged
gligneul added a commit to OffchainLabs/cargo-stylus that referenced this pull request Jun 24, 2025
@gligneul
Update Stylus Deployer address
4a709b4 
Apply the changes from OffchainLabs/nitro-testnode#117
Close STY-279
@gligneul gligneul mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gzeoneth gzeoneth gzeoneth left review comments

@tsahee tsahee tsahee approved these changes

@TucksonDev TucksonDev TucksonDev left review comments

@godzillaba godzillaba Awaiting requested review from godzillaba

Assignees

No one assigned

Labels

s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yahgwai @gzeoneth @tsahee @TucksonDev @godzillaba @eljobe @joshuacolvin0