V3 support#117
Merged
Merged
Conversation
This reverts commit 6e03e48.
yahgwai
marked this pull request as draft
February 21, 2025 15:39
gzeoneth
marked this pull request as ready for review
April 16, 2025 17:51
Member
|
I think we can merge this and resolve the outstanding TODOs later |
TucksonDev
previously approved these changes
May 6, 2025
TucksonDev
left a comment
TucksonDev
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Summarizing the open issues (we can potentially tackle these in a different PR):
- Issues with use-smart-contract-wallet : pointed out in this comment
- Issues with gas estimations sent from address 0x0. A workaround is in place here.
- This PR pins geth version to v1.14.13
Member
|
wait for nitro-contracts v3.1.1 release for OffchainLabs/nitro-contracts#338 change before merge |
Member
|
Ready to merge, with v3.1.1 stylus deployer factory (surfacing constructor error) it would be deployed at |
tsahee
approved these changes
Jun 18, 2025
gligneul
added a commit
to OffchainLabs/nitro-devnode
that referenced
this pull request
Jun 24, 2025
Apply the changes from OffchainLabs/nitro-testnode#117 The new CREATE2 address is 0xcEcba2F1DC234f70Dd89F2041029807F8D03A990 Close STY-280
gligneul
added a commit
to OffchainLabs/cargo-stylus
that referenced
this pull request
Jun 24, 2025
Apply the changes from OffchainLabs/nitro-testnode#117 Close STY-279
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releasebut notmaster