-
Notifications
You must be signed in to change notification settings - Fork 95
sync master and release branches #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "\u201Csync-master-release-10-01-2025\u201D"
Conversation
bump default token bridge contracts version
add flags for l2 and l3 traffic
if $l3_traffic; then | ||
echo == create l3 traffic | ||
run_script send-l3 --ethamount 10 --to user_traffic_generator --wait | ||
run_script send-l3 --ethamount 0.0001 --from user_traffic_generator --to user_traffic_generator --wait --delay 5000 --times 1000000 > /dev/null & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity - why do we need --delay
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its duration between successive transactions-
nitro-testnode/scripts/ethcommands.ts
Line 33 in 34f0e1c
if (argv.delay > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the poor wording of the question. Why do we need to set any delay? It looks like we have to do 1M transactions and sleep for 5s after every one
I see that this has already been the case, so of course I'm not treating this as a blocker or anything; it's just my curiosity... 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we set the delay between tx to move the chain in regular interval so that the chain keeps progressing- like new tx keep coming in causing the batch poster to post batches regularly, assertions being posted too etc etc... Without the delay 1M txs would be completed pretty quickly beating the purpose of traffic.. does that make sense?
closed by #155 |
This PR syncs the master and release branches of nitro-testnode