Skip to content

perf: common docker layer #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2024
Merged

perf: common docker layer #97

merged 5 commits into from
Nov 5, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Oct 28, 2024 •
edited
Loading

a few changes to reduce docker image size, also added a --nowait flag and fixed a bug with --init not building image

@cla-bot cla-bot bot added the s label Oct 28, 2024
@tsahee tsahee requested a review from Tristan-Wilson October 30, 2024 02:07
joshuacolvin0
joshuacolvin0 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 51e1d7a into release Nov 5, 2024
13 checks passed
@joshuacolvin0 joshuacolvin0 deleted the docker-layer branch November 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

Assignees

No one assigned

Labels

s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gzeoneth @joshuacolvin0