Update to the version of go-ethereum that supports arbos 40 #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Mar 26, 2025
tsahee
requested changes
Mar 29, 2025
This is important because processing a transaction could result in a new arbos version. Then, a later transaction in the same block, could start using the new SetCodeTxType and that wouldn't be supported unless the code was also using the updated Prague signer. The reason this wasn't necessary before, is that the signer being used could be derived from the header's time. And, in arbos 30-32, using the Cancun signer was a no-op because arbitrum didn't support BlobTxType transactions.
tsahee
requested changes
Mar 31, 2025
|
@tsahee, can you also add the |
The VersionedArbitrumSigner funciton would have made it harder to spot changes in the upstream go-ethereum project. So, we switched back to the idea of just having MakeSigner take an extra arbosVersion argument.
|
Looks like tests fail for a real reason @eljobe |
This picks up disabling EIP-7685 consensus layer request handling.
Tristan-Wilson
previously approved these changes
Apr 3, 2025
Tristan-Wilson
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: NIT-3139 and NIT-3173
Pulls in OffchainLabs/go-ethereum#434