Gas Dimension Trace Tests: Nested Call Tests #3354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljobe
approved these changes
Jun 26, 2025
eljobe
requested changes
Jun 26, 2025
relyt29
force-pushed
the
relyt29/nested-call-tests
branch
from
154728d to
d72b138
Compare
relyt29
force-pushed
the
relyt29/nested-call-tests
branch
from
d72b138 to
61067ef
Compare
eljobe
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests an additional type of test case missed in #3233 where a call makes another call to another contract.
All of the other calls only checked correct gas dimensions for a call stack of depth one.
Depends on the work in OffchainLabs/go-ethereum#476 which fixes 2 pretty big bugs in the gas dimension tracer that were causing a large number of errors while live tracing transactions