-
Notifications
You must be signed in to change notification settings - Fork 644
Refactor consensus-execution sync to push sync data #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3df0ffc
Refactor consensus-execution sync to push sync data
Tristan-Wilson 8418a7d
Start the ConsensusExecutionSyncer for l2-only mode
Tristan-Wilson 11ef4b7
Merge branch 'master' into consensus-pushes-sync-info
Tristan-Wilson 07dd219
Merge remote-tracking branch 'origin/master' into consensus-pushes-sy…
Tristan-Wilson 3d0834c
Fix review comments about sync timing issues
Tristan-Wilson cfc1913
Add SyncMonitor default to ConfigDefault
Tristan-Wilson 5630184
Merge branch 'master' into consensus-pushes-sync-info
Tristan-Wilson 4756bfd
Sleep to give time for ConsensusExecutionSyncer
Tristan-Wilson 2473e0b
Address PR review comments on sync monitor
Tristan-Wilson 47c85ff
Merge remote-tracking branch 'origin/master' into consensus-pushes-sy…
Tristan-Wilson 82de959
Merge branch 'master' into consensus-pushes-sync-info
Tristan-Wilson 8258a39
Merge branch 'master' into consensus-pushes-sync-info
Tristan-Wilson b0c9f4f
Merge branch 'master' into consensus-pushes-sync-info
Tristan-Wilson 50e0d86
Change consensus sync interval, remove TODO
Tristan-Wilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SyncProgressMap should be nil or empty if Synced (prevents wasteful locking/etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in latest commit.