fix: WithMockBridge to actually enable mock bridge #3584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
go-test CI runs are failing with |
|
I'm closing this PR for now. Please open a fresh one if you intend to pick the work up and respond to review feedback in a timely manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option WithMockBridge was inverted and set useMockBridge = false, which disabled the mock bridge. This caused a semantic mismatch with callers and tests that expect WithMockBridge() to deploy mocks. The deploy path already uses useMockBridge to choose between mocksgen.DeployBridgeStub (mock) and bridgegen.DeployBridge (real), so setting it to true here aligns the option name with behavior and avoids ABI mismatches in tests and deployments.