fix: missing reassignment of rivals when recording creation times in block snapshot #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GarmashAlex
commented
Sep 11, 2025
GarmashAlex
commented
- This change reassigns variables a and b to the correct rival edges (blk-4.a-6.a and blk-4.a-6.b) before calling CreatedAtBlock() in setupBlockChallengeTreeSnapshot.
- Without this, the creation times map for mutual blk-4.a-6.* incorrectly reused the prior pair (blk-4.a-8.*), leading to wrong rival timing data under the same mutualId.
- Big and small step snapshots already reassign a/b; this aligns the block snapshot with that pattern and ensures accurate rival creation times for downstream logic like rivalsWithCreationTimes and local timer computations.
rauljordan
approved these changes
Sep 19, 2025
|
Tagging @joshuacolvin0 for a design approval label |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
auto-merge was automatically disabled
September 26, 2025 07:07
Pull Request is not mergeable
Merged
via the queue into
OffchainLabs:master
with commit Sep 26, 2025
a964782
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.