fix: correct safe-wait delta calculation in edge tracker and transact #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
Sep 19, 2025
|
Requesting @joshuacolvin0 for design approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the wait duration when a transaction is not yet “safe”. Previously, if the safe head S lagged behind the receipt block B (S < B), we computed a zero-delay wait, causing hot polling. Now we wait for (B - S) blocks times the average block time.
This change is necessary to prevent tight polling loops and to align the waiting logic with the intended semantics: only proceed once the safe head has caught up to the receipt’s block.