Skip to content

Conversation

maradini77
Copy link
Contributor

  • Summary: Propagate cancellation and add a 30s timeout to external signer RPC calls instead of using context.TODO.
  • What/Why:
    • Prevents indefinite hangs during shutdown or signer stalls.
    • Ensures RPC calls respect upstream cancellation and deadlines.
  • Changes:
    • arbnode/dataposter/data_poster.go: use context.WithTimeout(ctx, 30*time.Second) in TransactOpts.Signer.

@eljobe eljobe self-assigned this Sep 22, 2025
@eljobe
Copy link
Member

eljobe commented Sep 23, 2025

I don't believe this change either behaves as described in the PR description, or is safe and compatible with our codebase.

The DataPoster is a long-lived object, the lifecycle of the context object with which a new instance was created might be quite different than the lifecycle of the external signer being created for it to use when posting data to the parent chain.

These are not per-request contexts. They are essentially process-scoped contexts.

Closing.

@eljobe eljobe closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants