Skip to content

Conversation

viktorking7
Copy link
Contributor

Description

  • What:

    • Remove http:// scheme from http.Server.Addr (use host:port).
    • Add 10s timeout to Shutdown to avoid indefinite hangs.
  • Why:

    • Addr expects host:port; including a scheme is incorrect and misleading.
    • Bounded graceful shutdown improves reliability under stuck handlers.
  • Impact:

    • More correct server configuration and safer shutdown behavior.
    • No behavior change for Serve(listener) path.

@Tristan-Wilson Tristan-Wilson added this pull request to the merge queue Sep 23, 2025
Merged via the queue into OffchainLabs:master with commit df88329 Sep 23, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants