-
Notifications
You must be signed in to change notification settings - Fork 644
Fail the can_proceed job instead of skipping it #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the can_proceed
job in the GitHub Actions workflow to fail explicitly instead of being skipped when required jobs don't meet success criteria. The change improves workflow visibility by ensuring the gate job always runs and provides clear feedback about job statuses.
- Replaces conditional job execution with explicit failure logic
- Adds dynamic result checking for all dependent jobs in a loop
- Provides clearer error messaging when jobs fail
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
No description provided.