Skip to content

Conversation

maradini77
Copy link
Contributor

Description:

  • Summary: Ensure Badger DB is closed in the migration path of DBStorageService to avoid file descriptor leaks and stale locks.
  • What changed: Added ret.db.Close() on both success and error paths when target != nil in daprovider/das/db_storage_service.go.
  • Rationale: Previously, the DB was opened but not closed during migration, causing a real resource leak.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2025

CLA assistant check
All committers have signed the CLA.

@eljobe eljobe self-assigned this Sep 23, 2025
@eljobe eljobe assigned Tristan-Wilson and unassigned eljobe Sep 23, 2025
@maradini77
Copy link
Contributor Author

@Tristan-Wilson

@eljobe
Copy link
Member

eljobe commented Sep 24, 2025

@Tristan-Wilson

I respectfully request that you trust that when we have someone assigned to a PR, that we will prioritize reviewing it at the time that best aligns with our team's priorities. To that end, please refrain from updates on PRs like this one in the future.

@maradini77
Copy link
Contributor Author

I respectfully request that you trust that when we have someone assigned to a PR, that we will prioritize reviewing it at the time that best aligns with our team's priorities. To that end, please refrain from updates on PRs like this one in the future.

okay, sorry

@Tristan-Wilson
Copy link
Member

Thanks for reminding me that we had deprecated the AnyTrust DBStorageService code over a year ago. I made a different PR to remove it #3701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants