-
Notifications
You must be signed in to change notification settings - Fork 644
add debug block injection to prefund devwallet #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
08204a0
to
b4f61c3
Compare
b4f61c3
to
0fa4d20
Compare
❌ 6 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end
func (c *Config) Apply(_ *params.ChainConfig) { | ||
// do nothing | ||
} | ||
|
||
func ConfigAddOptions(_ string, _ *pflag.FlagSet) { | ||
// don't add any of debug block options | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (c *Config) Apply(_ *params.ChainConfig) { | |
// do nothing | |
} | |
func ConfigAddOptions(_ string, _ *pflag.FlagSet) { | |
// don't add any of debug block options | |
} |
if these don't do anything shouldn't we just not add them? if we need them in the future we can add them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually need those defined for the the production builds that are without debugblock
build flag. Then we want those to be just stubs and have no effect.
Co-authored-by: Kolby Moroz Liebl <[email protected]>
Resolves NIT-3912
This PR adds tooling for benchmarking purposes. All the experimental features added are guarded by
debugblock
build tag.When
debugblock
tag is used following configs options are exposed:node.dangerous.debug-block.overwrite-chain-config
- when set triggers chain config overwrite in database on startup, settingArbitrumChainParams.AllowDebugPrecompiles
to true and configuringArbitrumChainParams.DebugBlock
andArbitrumChainParams.DebugAddress
to values specified by configs described belownode.dangerous.debug-block.debug-blocknum
- specifies the block number of the debug block we want to injectnode.dangerous.debug-block.debug-address
- specifies the address of account that will be funded in the debug blockPulls: OffchainLabs/go-ethereum#548