Skip to content

add tx streamer message processing duration metric #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+7 −0
Open

add tx streamer message processing duration metric #3698

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67ff1c1
add txstreamer message timer metric
magicxyyz Sep 23, 2025
c54b1fe
Merge branch 'master' into txstreamer-message-timer
magicxyyz Sep 26, 2025
5e8a6c7
rename txstreamer message metric
magicxyyz Oct 7, 2025
289a655
Merge branch 'master' into txstreamer-message-timer
magicxyyz Oct 7, 2025
c9d06fe
Merge branch 'master' into txstreamer-message-timer
magicxyyz Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion arbnode/transaction_streamer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"github.com/ethereum/go-ethereum/core/rawdb"
"github.com/ethereum/go-ethereum/ethdb"
"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/metrics"
"github.com/ethereum/go-ethereum/params"
"github.com/ethereum/go-ethereum/rlp"

Expand All @@ -39,6 +40,10 @@ import (
"github.com/offchainlabs/nitro/util/stopwaiter"
)

var (
messageTimer = metrics.NewRegisteredHistogram("arb/txstreamer/message/duration", nil, metrics.NewBoundedHistogramSample())
)

// TransactionStreamer produces blocks from a node's L1 messages, storing the results in the blockchain and recording their positions
// The streamer is notified when there's new batches to process
type TransactionStreamer struct {
Expand Down Expand Up @@ -1339,6 +1344,7 @@ func (s *TransactionStreamer) ExecuteNextMsg(ctx context.Context) bool {
return false
}
defer s.reorgMutex.RUnlock()
start := time.Now()

prevHeadMsgIdx := s.prevHeadMsgIdx
consensusHeadMsgIdx, err := s.GetHeadMessageIndex()
Expand Down Expand Up @@ -1406,7 +1412,7 @@ func (s *TransactionStreamer) ExecuteNextMsg(ctx context.Context) bool {
BlockMetadata: msgAndBlockInfo.BlockMetadata,
}
s.broadcastMessages([]arbostypes.MessageWithMetadataAndBlockInfo{msgWithBlockInfo}, msgIdxToExecute)

messageTimer.Update(time.Since(start).Nanoseconds())
return msgIdxToExecute+1 <= consensusHeadMsgIdx
}

Expand Down
Loading