Skip to content

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Oct 7, 2025

Copy link

github-actions bot commented Oct 7, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
2142 5 2137 0
View the top 3 failed tests by shortest run time
TestValidationInputsAtWithWasmTarget
Stack Traces | 2.510s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90m4	1	POP	[0xe6fa28a9af54b5d5249433c74a6bc216295e2e16be06fa3c22cb2d5569e443db]�[0;0m
�[90m5	1	STOP	[]�[0;0m
�[90mCall trace:�[0;0m
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0x41 0x0 0x0]�[0;0m
�[90m3	1	TSTORE	[0xc8c60832905f243dbf88248ab283e06e9cff5a97e73d29ee1da279c28ef290c2 0x4b6ec701a305e81b32c0a07c8499b61d9d41c2833d5ff7ce16cfd1eb4ca32332]�[0;0m
�[90m4	1	STOP	[]�[0;0m
ERROR[10-15|15:18:40.105] Dangling trie nodes after full cleanup
�[90mCall trace:�[0;0m
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0x21 0x0 0x0]�[0;0m
�[90m3	1	TLOAD	[0x4b6ec701a305e81b32c0a07c8499b61d9d41c2833d5ff7ce16cfd1eb4ca32332]�[0;0m
�[90m4	1	POP	[0x0]�[0;0m
�[90m5	1	RETURN	[0x20 0x0]�[0;0m
ERROR[10-15|15:18:40.128] Dangling trie nodes after full cleanup
--- FAIL: TestValidationInputsAtWithWasmTarget (2.51s)
TestBroadcastClientConfirmedMessage
Stack Traces | 5.020s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestBroadcastClientConfirmedMessage
INFO [10-15|15:04:45.556] arbitrum websocket broadcast server is listening address=[::]:36945
INFO [10-15|15:04:45.556] arbitrum websocket broadcast server is listening address=[::]:34395
INFO [10-15|15:04:45.556] arbitrum websocket broadcast server is listening address=[::]:38141
INFO [10-15|15:04:45.556] arbitrum websocket broadcast server is listening address=[::]:35393
    broadcastclient_test.go:387: broadcasting seq 0 message
INFO [10-15|15:04:45.557] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:38141/
INFO [10-15|15:04:45.557] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:36945/
INFO [10-15|15:04:45.557] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:35393/
INFO [10-15|15:04:45.561] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:34395/
INFO [10-15|15:04:45.561] Feed connected                           feedServerVersion=2 chainId=9742 requestedSeqNum=0
INFO [10-15|15:04:45.561] Feed connected                           feedServerVersion=2 chainId=8742 requestedSeqNum=0
INFO [10-15|15:04:45.564] Feed connected                           feedServerVersion=2 chainId=8744 requestedSeqNum=0
INFO [10-15|15:04:45.566] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:34395/
INFO [10-15|15:04:45.569] Feed connected                           feedServerVersion=2 chainId=8742 requestedSeqNum=0
ERROR[10-15|15:04:45.569] error validating feed signature          error="signature not verified: signer not approved" "sequence number"=0
    broadcastclient_test.go:397: Received Message, Sequence Message: {0 {0xc00041a450 0} <nil> [118 47 5 141 150 201 71 209 255 77 51 136 174 249 93 117 137 2 227 124 15 78 114 118 192 74 44 125 138 208 64 110 5 249 236 176 8 227 85 126 30 202 88 63 12 247 122 85 40 99 218 51 201 144 127 122 91 0 22 10 116 178 26 58 1] [] 0}
WARN [10-15|15:04:45.571] confirmed sequence number is past the end of stored messages "confirmed sequence number"=42 "last stored sequence number"=0
    broadcastclient_test.go:418: Client did not receive confirm message
--- FAIL: TestBroadcastClientConfirmedMessage (5.02s)
TestVersion30
Stack Traces | 10.340s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mstorage: deployed to 0xEba70C09bA17508c75227cCACf376975490172c3�[0;0m
�[90mTime to activate storage: 125.449552ms�[0;0m
    precompile_inclusion_test.go:90: goroutine 454896 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082610, 0xc0521cae00}, {0x4040840, 0xc10af01140}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0521cae00, {0x4040840, 0xc10af01140}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0521cae00, 0x1e, {0xc0709efdb0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc0521cae00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0521cae00, 0x3ccaac0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (10.34s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the check-multi-dimensional-gas-in-block-re-execution branch from 8380e75 to f76ff64 Compare October 8, 2025 09:30
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 8, 2025 10:27
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

gligneul
gligneul previously approved these changes Oct 8, 2025
@gligneul gligneul assigned eljobe and unassigned gligneul Oct 8, 2025
@MishkaRogachev MishkaRogachev force-pushed the check-multi-dimensional-gas-in-block-re-execution branch from 425b696 to 151a997 Compare October 15, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants