-
Notifications
You must be signed in to change notification settings - Fork 644
Add arb_getMinRequiredNitroVersion endpoint that returns minimum required version of the nitro node software #3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ganeshvanahalli
wants to merge
2
commits into
master
Choose a base branch
from
add-nodeversionalerter-endpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+356
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired version of the nitro node software
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
amsanghi
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint to arb namespace called
arb_getMinRequiredNitroVersion
that returns three strings corresponding to the--node.version-alerter-server.*
config options as stated below, rpc can be enabled bySubsequently on the client side a node can connect to such an endpoint via
--version-alerter.*
config optionsthe node gets the data from
arb_getMinRequiredNitroVersion
endpoint -> checks if it is below the required minimum version by number or by date -> if yes, then logs the upgrade message at appropriate level ->Testing Done
TestNitroNodeVersionAlerter
system test has been added testing multiple scenarios and verified that logs are as expected.Resolves NIT-3441