fix: prevent HTTP connection reuse in BlobClient error recovery #3811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-Wilson
approved these changes
Oct 15, 2025
|
I think this is fine to include in 3.9.x |
auto-merge was automatically disabled
October 16, 2025 10:20
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
OffchainLabs:master
with commit Oct 16, 2025
f4e849e
21 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
BlobClientattempts to recover from beacon API errors by creating a newhttp.Client, but uses the default client which shares the global connection pool. This defeats the purpose of trying to avoid problematic connections when switching between load-balanced backends.Solution
Replace
&http.Client{}with&http.Client{Transport: &http.Transport{DisableKeepAlives: true}}in the error recovery path to force fresh TCP connections.