Skip to content

fix: script behavior for safer execution and error handling #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: script behavior for safer execution and error handling #3823

wants to merge 2 commits into from
+6 −3

Conversation

famouswizard
Copy link

fixed a few things so the script behaves better:

  • always cd to the script’s directory.
  • exit with 1 on errors instead of continuing silently.
  • set exit_status=0 upfront to avoid surprises with timeout.

@Tristan-Wilson Tristan-Wilson requested a review from eljobe October 15, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tristan-Wilson Tristan-Wilson Tristan-Wilson approved these changes

@eljobe eljobe Awaiting requested review from eljobe

Assignees

@eljobe eljobe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@famouswizard @Tristan-Wilson @eljobe