Skip to content

Toggle rpc endpoint used on errors #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Toggle rpc endpoint used on errors #3834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e5b54d
Toggle rpc endpoint used on errors
eljobe Oct 14, 2025
39614c1
Also, add a dangerous flag to skip blob proof verification
eljobe Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 39 additions & 16 deletions util/headerreader/blob_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,26 @@ type BlobClient struct {

// Directory to save the fetched blobs
blobDirectory string

// Dangerous options
skipBlobProofVerification bool
}

type BlobClientDangerousConfig struct {
SkipBlobProofVerification bool `koanf:"skip-blob-proof-verification"`
}

type BlobClientConfig struct {
BeaconUrl string `koanf:"beacon-url"`
SecondaryBeaconUrl string `koanf:"secondary-beacon-url"`
BlobDirectory string `koanf:"blob-directory"`
Authorization string `koanf:"authorization"`
UseLegacyEndpoint bool `koanf:"use-legacy-endpoint"`
BeaconUrl string `koanf:"beacon-url"`
SecondaryBeaconUrl string `koanf:"secondary-beacon-url"`
BlobDirectory string `koanf:"blob-directory"`
Authorization string `koanf:"authorization"`
UseLegacyEndpoint bool `koanf:"use-legacy-endpoint"`
Dangerous BlobClientDangerousConfig `koanf:"dangerous"`
}

var DefaultDangerousConfig = BlobClientDangerousConfig{
SkipBlobProofVerification: false,
}

var DefaultBlobClientConfig = BlobClientConfig{
Expand All @@ -59,6 +71,7 @@ var DefaultBlobClientConfig = BlobClientConfig{
BlobDirectory: "",
Authorization: "",
UseLegacyEndpoint: false,
Dangerous: DefaultDangerousConfig,
}

func BlobClientAddOptions(prefix string, f *pflag.FlagSet) {
Expand All @@ -67,6 +80,11 @@ func BlobClientAddOptions(prefix string, f *pflag.FlagSet) {
f.String(prefix+".blob-directory", DefaultBlobClientConfig.BlobDirectory, "Full path of the directory to save fetched blobs")
f.String(prefix+".authorization", DefaultBlobClientConfig.Authorization, "Value to send with the HTTP Authorization: header for Beacon REST requests, must include both scheme and scheme parameters")
f.Bool(prefix+".use-legacy-endpoint", DefaultBlobClientConfig.UseLegacyEndpoint, "Use the legacy blob_sidecars endpoint instead of the blobs endpoint")
BlobClientDangerousAddOptions(prefix+".dangerous", f)
}

func BlobClientDangerousAddOptions(prefix string, f *pflag.FlagSet) {
f.Bool(prefix+".skip-blob-proof-verification", DefaultDangerousConfig.SkipBlobProofVerification, "DANGEROUS! Skips verification of KZG proofs for blobs fetched from the beacon node.")
}

func NewBlobClient(config BlobClientConfig, ec *ethclient.Client) (*BlobClient, error) {
Expand All @@ -92,12 +110,13 @@ func NewBlobClient(config BlobClientConfig, ec *ethclient.Client) (*BlobClient,
}
}
blobClient := &BlobClient{
ec: ec,
beaconUrl: beaconUrl,
secondaryBeaconUrl: secondaryBeaconUrl,
authorization: config.Authorization,
useLegacyEndpoint: config.UseLegacyEndpoint,
blobDirectory: config.BlobDirectory,
ec: ec,
beaconUrl: beaconUrl,
secondaryBeaconUrl: secondaryBeaconUrl,
authorization: config.Authorization,
useLegacyEndpoint: config.UseLegacyEndpoint,
blobDirectory: config.BlobDirectory,
skipBlobProofVerification: config.Dangerous.SkipBlobProofVerification,
}
blobClient.httpClient.Store(&http.Client{})
return blobClient, nil
Expand Down Expand Up @@ -201,6 +220,8 @@ func (b *BlobClient) GetBlobsBySlot(ctx context.Context, slot uint64, versionedH
// we can potentially connect to a different, and healthy, beacon chain node in the next request.
b.httpClient.Store(&http.Client{})

b.useLegacyEndpoint = !b.useLegacyEndpoint

return nil, fmt.Errorf("error fetching blobs for slot %d: %w", slot, err)
}
return blobs, nil
Expand Down Expand Up @@ -320,12 +341,14 @@ func (b *BlobClient) blobSidecars(ctx context.Context, slot uint64, versionedHas

copy(output[outputIdx][:], blobItem.Blob)

var proof kzg4844.Proof
copy(proof[:], blobItem.KzgProof)
if !b.skipBlobProofVerification {
var proof kzg4844.Proof
copy(proof[:], blobItem.KzgProof)

err = kzg4844.VerifyBlobProof(&output[outputIdx], commitment, proof)
if err != nil {
return nil, fmt.Errorf("failed to verify blob proof for blob at slot(%d) at index(%d), blob(%s)", slot, blobItem.Index, pretty.FirstFewChars(blobItem.Blob.String()))
err = kzg4844.VerifyBlobProof(&output[outputIdx], commitment, proof)
if err != nil {
return nil, fmt.Errorf("failed to verify blob proof for blob at slot(%d) at index(%d), blob(%s)", slot, blobItem.Index, pretty.FirstFewChars(blobItem.Blob.String()))
}
}
}

Expand Down
Loading