Skip to content

Fix out of bounds config access in dataposter #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Fix out of bounds config access in dataposter #3838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion arbnode/dataposter/data_poster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,10 @@ func (p *DataPoster) Start(ctxIn context.Context) {
log.Warn("failed to update tx poster nonce", "err", err)
}
now := time.Now()
nextCheck := now.Add(arbmath.MinInt(p.config().ReplacementTimes[0], p.config().BlobTxReplacementTimes[0]))
nextCheck := now.Add(p.config().ReplacementTimes[0])
if len(p.config().BlobTxReplacementTimes) > 0 {
nextCheck = now.Add(arbmath.MinInt(p.config().ReplacementTimes[0], p.config().BlobTxReplacementTimes[0]))
}
maxTxsToRbf := p.config().MaxMempoolTransactions
if maxTxsToRbf == 0 {
maxTxsToRbf = 512
Expand Down Expand Up @@ -1413,6 +1416,12 @@ func (c *DataPosterConfig) Validate() error {
default:
return fmt.Errorf("invalid enable-cell-proofs value %q (valid: \"\", \"auto\", \"force-enable\", \"force-disable\")", c.EnableCellProofs)
}
if len(c.ReplacementTimes) == 0 {
return fmt.Errorf("replacement-times must have at least one value")
}
if c.Post4844Blobs && len(c.BlobTxReplacementTimes) == 0 {
return fmt.Errorf("blob-tx-replacement-times must have at least one value when post-4844-blobs is enabled")
}
return nil
}

Expand Down
Loading