Skip to content

Conversation

vtjl10
Copy link
Contributor

@vtjl10 vtjl10 commented Oct 15, 2025

Summary: Adds a nil check for resp.HTTPResponse before accessing StatusCode in cmd/nitro/init.go to prevent a panic on transport errors.

  • Behavior: Still returns notFoundError on 404, but only when an HTTP response is present; otherwise logs the attempt and continues retry logic.
  • Rationale: Improves robustness of the init download path; avoids process crashes under transient network failures.

@Tristan-Wilson
Copy link
Member

I believe HTTPResponse can be empty here in case of connection issues, so this will prevent a nil deref in the downloader.

@vtjl10
Copy link
Contributor Author

vtjl10 commented Oct 16, 2025

@Tristan-Wilson how I can fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants