Skip to content

fix: Ensure file is always closed when saving blobs to disk #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: Ensure file is always closed when saving blobs to disk #3845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/headerreader/blob_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,14 +374,14 @@ func saveBlobDataToDisk(rawData json.RawMessage, slot uint64, blobDirectory stri
return fmt.Errorf("could not create file to store fetched blobs")
}
full := fullResult[json.RawMessage]{Data: rawData}
defer file.Close()
fullbytes, err := json.Marshal(full)
if err != nil {
return fmt.Errorf("unable to marshal data into bytes while attempting to store fetched blobs")
}
if _, err := file.Write(fullbytes); err != nil {
return fmt.Errorf("failed to write blob data to disk")
}
file.Close()
return nil
}

Expand Down