Don't treat error as fatal when signature behavior fails

[amsanghi]

Fixes: NIT-4017

The idea is we should log error, and now continue processing the message when signature errors out, so we just skip the message if signature errors out.

[github-actions]

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
2144	5	2139	0

View the top 3 failed tests by shortest run time

TestOutOfGasInStorageCacheFlush

Stack Traces | 3.040s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestOutOfGasInStorageCacheFlush
    program_test.go:2813: goroutine 687290 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40837d0, 0xc0a0bc0a80}, {0x4041580, 0xc0a3dde6c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0a0bc0a80, {0x4041580, 0xc0a3dde6c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc0a0bc0a80)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc0a0bc0a80, 0x3ccb6a8)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
ERROR[10-17|09:51:16.757] Dangling trie nodes after full cleanup
INFO [10-17|09:51:16.764] HTTP server stopped                      endpoint=127.0.0.1:36561
TRACE[10-17|09:51:16.764] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (3.04s)

TestPrimaryToSecondaryFailover

Stack Traces | 5.430s run time

=== RUN   TestPrimaryToSecondaryFailover
=== PAUSE TestPrimaryToSecondaryFailover
=== CONT  TestPrimaryToSecondaryFailover
INFO [10-17|09:42:57.356] arbitrum websocket broadcast server is listening address=[::]:42863
    broadcastclients_test.go:203: Primary broadcaster listening on: [::]:42863
INFO [10-17|09:42:57.356] arbitrum websocket broadcast server is listening address=[::]:44101
    broadcastclients_test.go:204: Secondary broadcaster listening on: [::]:44101
    broadcastclients_test.go:227: Primary URL: ws://127.0.0.1:42863
    broadcastclients_test.go:228: Secondary URL: ws://127.0.0.1:44101
INFO [10-17|09:42:57.361] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:42863
INFO [10-17|09:42:57.364] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=0
    broadcastclients_test.go:275: Phase 1: Sending messages from primary broadcaster
INFO [10-17|09:43:02.573] secondary feed started                   url=ws://127.0.0.1:44101 startingFromSeq=4
INFO [10-17|09:43:02.573] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:44101
INFO [10-17|09:43:02.574] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=4
    broadcastclients_test.go:307: Timed out waiting for message 5/5 from primary
--- FAIL: TestPrimaryToSecondaryFailover (5.43s)

TestVersion40

Stack Traces | 7.170s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 3 in 221.38ms�[0;0m
    precompile_inclusion_test.go:90: goroutine 454801 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40837d0, 0xc05df76e00}, {0x4041a00, 0xc09a4a3ce0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc05df76e00, {0x4041a00, 0xc09a4a3ce0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc05df76e00, 0x28, {0xc06f621df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc05df76e00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc05df76e00, 0x3ccbb80)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
�[90mink price=9841�[0;0m
--- FAIL: TestVersion40 (7.17s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[tsahee]

LGTM

[eljobe]

@amsanghi there appear to be merge conflicts. Can you take a look?

[amsanghi]

@amsanghi there appear to be merge conflicts. Can you take a look?

Done.