fix(server_common): invoke callback only when machine retrieval succeeds #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sashaodessa wants to merge 1 commit into OffchainLabs:master from sashaodessa:patch-8

+1 −1

Contributor

sashaodessa commented Oct 16, 2025

Summary: Ensure ForEachReadyMachine calls the callback only on successful machine retrieval.
Problem: The callback was executed when stat.Current() returned an error (inverted condition), risking nil/invalid machine usage.
Solution: Invert the condition to run the callback only if err == nil.


          Update machine_loader.go

192a886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet