Skip to content

Conversation

maximevtush
Copy link
Contributor

Description

  • Summary: Ensure ForEachReadyMachine invokes callback only on successful machine retrieval; add bounded write deadline for client writes.
  • Problem:
    • validator/server_common/machine_loader.go: callback executed when stat.Current() returned an error.
    • wsbroadcastserver/clientconnection.go: conn.Write could block indefinitely on slow/stalled clients.
  • Solution:
    • Invert condition to call callback only if err == nil.
    • Set and reset a write deadline (10s) around conn.Write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant